Stop using UMap in favor of Accounts type family#5128
Merged
Conversation
lehins
force-pushed
the
lehins/era-specific-umap
branch
from
0fa485d to
ca95503
Compare
teodanciu
reviewed
Jun 25, 2025
Contributor
teodanciu
left a comment
teodanciu
left a comment
There was a problem hiding this comment.
Did a first pass, will have another look later! Looks great, I finally feel I can be friends with DState 😆
aniketd
reviewed
Jun 26, 2025
teodanciu
reviewed
Jun 26, 2025
Contributor
teodanciu
left a comment
teodanciu
left a comment
There was a problem hiding this comment.
Added a few more minor suggestions
eras/shelley/impl/src/Cardano/Ledger/Shelley/LedgerState/PulsingReward.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Rules/Deposits.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/Examples/Combinators.hs
Show resolved
Hide resolved
teodanciu
reviewed
Jun 26, 2025
teodanciu
reviewed
Jun 26, 2025
teodanciu
approved these changes
Jun 26, 2025
Contributor
teodanciu
left a comment
teodanciu
left a comment
There was a problem hiding this comment.
That a huge piece of work!! I think it's a great improvement in terms of understanding not only what we store/map but also how to work with it, thanks to the clear interface.
I admit I got lost with the Transition modules, I don't understand at all what they're about, but that's on me, I shall study them.
Looks good to me, great work!
lehins
force-pushed
the
lehins/era-specific-umap
branch
3 times, most recently
from
6c37635 to
afaa57f
Compare
TimSheard
force-pushed
the
lehins/era-specific-umap
branch
3 times, most recently
from
f802c1e to
5eeb3a8
Compare
lehins
force-pushed
the
lehins/era-specific-umap
branch
from
0587e7f to
c45599a
Compare
TimSheard
force-pushed
the
lehins/era-specific-umap
branch
4 times, most recently
from
0eaa472 to
1d65cea
Compare
lehins
force-pushed
the
lehins/era-specific-umap
branch
from
1d65cea to
b572293
Compare
TimSheard
force-pushed
the
lehins/era-specific-umap
branch
2 times, most recently
from
08d299b to
511bf0e
Compare
lehins
force-pushed
the
lehins/era-specific-umap
branch
6 times, most recently
from
59db22c to
cf64cb7
Compare
10 tasks
lehins
force-pushed
the
lehins/era-specific-umap
branch
from
cf64cb7 to
91337ed
Compare
lehins
force-pushed
the
lehins/era-specific-umap
branch
2 times, most recently
from
7fe644a to
aebc670
Compare
lehins
force-pushed
the
lehins/era-specific-umap
branch
2 times, most recently
from
dad8b64 to
c8fd673
Compare
Introduce two type families for `Accounts` and `AccountState` that have different representation for Conway era and era before it
lehins
force-pushed
the
lehins/era-specific-umap
branch
from
c8fd673 to
a40f047
Compare
This was referenced Aug 11, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4694
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).